test: PHPUnit upgrade

composer.json

@@ -30,6 +30,6 @@
     },
     "require-dev": {
         "composer/composer": "^2.5",
-        "phpunit/phpunit": "^10.0"
+        "phpunit/phpunit": "^11.3"
     }
 }

phpunit.xml

 <?xml version="1.0" encoding="UTF-8"?>
-<phpunit xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
-         xsi:noNamespaceSchemaLocation="https://schema.phpunit.de/10.0/phpunit.xsd"
-         bootstrap="vendor/autoload.php"
-         cacheDirectory=".phpunit.cache"
-         executionOrder="depends,defects"
-         requireCoverageMetadata="true"
-         beStrictAboutCoverageMetadata="true"
-         beStrictAboutOutputDuringTests="true"
-         failOnRisky="true"
-         failOnWarning="true">
-    <testsuites>
-        <testsuite name="default">
-            <directory>tests</directory>
-        </testsuite>
-    </testsuites>
-
-    <coverage>
-        <include>
-            <directory suffix=".php">src</directory>
-        </include>
-    </coverage>
+<phpunit xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:noNamespaceSchemaLocation="https://schema.phpunit.de/11.3/phpunit.xsd" bootstrap="vendor/autoload.php" cacheDirectory=".phpunit.cache" executionOrder="depends,defects" requireCoverageMetadata="true" beStrictAboutCoverageMetadata="true" beStrictAboutOutputDuringTests="true" failOnRisky="true" failOnWarning="true">
+  <testsuites>
+    <testsuite name="default">
+      <directory>tests</directory>
+    </testsuite>
+  </testsuites>
+  <source>
+    <include>
+      <directory suffix=".php">src</directory>
+    </include>
+  </source>
 </phpunit>

tests/Config/PreferredInstallTest.php

@@ -7,12 +7,12 @@ use Composer\Config;
 use Composer\Package\Link;
 use Composer\Package\RootPackage;
 use Composer\Semver\Constraint\Constraint;
+use PHPUnit\Framework\Attributes\CoversClass;
+use PHPUnit\Framework\Attributes\DataProvider;
 use PHPUnit\Framework\TestCase;
 use Spip\Composer\Config\PreferredInstall;
 
-/**
- * @covers Spip\Composer\Config\PreferredInstall
- */
+#[CoversClass(PreferredInstall::class)]
 class PreferredInstallTest extends TestCase
 {
     private PreferredInstall $preferredInstall;
@@ -62,7 +62,7 @@ class PreferredInstallTest extends TestCase
             ],
             'empty' => [
                 'expected' => [],
-                'prefered' => [],
+                'preferred' => [],
                 'requires' => [],
                 'extra' => [],
             ],
@@ -71,7 +71,7 @@ class PreferredInstallTest extends TestCase
                     dirname(__DIR__, 2) . '/plugins-dist/one/mandatory1',
                     dirname(__DIR__, 2) . '/squelettes-dist',
                 ],
-                'prefered' => ['one/*' => 'source', 'two/*' => 'source'],
+                'preferred' => ['one/*' => 'source', 'two/*' => 'source'],
                 'requires' => [
                     'mandatory1' => new Link('mandatory', 'one/mandatory1', new Constraint('=',  '*')),
                     'template2' => new Link('template', 'two/template2', new Constraint('=',  '*')),
@@ -89,9 +89,7 @@ class PreferredInstallTest extends TestCase
         ];
     }
 
-    /**
-     * @dataProvider dataGetFromConfig
-     */
+    #[DataProvider('dataGetFromConfig')]
     public function testGetFromConfig($expected, $preferred, $requires, $extra)
     {
         $this->package->setRequires($requires);

tests/Git/RemoteUrlsTest.php

@@ -4,12 +4,12 @@ namespace Spip\Test\Composer\Git;
 
 use Composer\IO\NullIO;
 use Composer\Util\ProcessExecutor;
+use PHPUnit\Framework\Attributes\CoversClass;
+use PHPUnit\Framework\Attributes\DataProvider;
 use PHPUnit\Framework\TestCase;
 use Spip\Composer\Git\RemoteUrls;
 
-/**
- * @covers Spip\Composer\Git\RemoteUrls
- */
+#[CoversClass(RemoteUrls::class)]
 class RemoteUrlsTest extends TestCase
 {
     private RemoteUrls $changer;
@@ -37,9 +37,7 @@ class RemoteUrlsTest extends TestCase
         ];
     }
 
-    /**
-     * @dataProvider dataHttpsToSsh
-     */
+    #[DataProvider('dataHttpsToSsh')]
     public function testToSsh($expected, $url)
     {
         $this->assertSame($expected, $this->changer->toSsh($url));
@@ -63,9 +61,7 @@ class RemoteUrlsTest extends TestCase
         ];
     }
 
-    /**
-     * @dataProvider dataSshToHttps
-     */
+    #[DataProvider('dataSshToHttps')]
     public function testToHttps($expected, $url)
     {
         $this->assertSame($expected, $this->changer->toHttps($url));

tests/SpipInstallerTest.php

@@ -6,13 +6,13 @@ use Composer;
 use Composer\Package\Package;
 use Composer\Package\RootPackage;
 use InvalidArgumentException;
+use PHPUnit\Framework\Attributes\CoversClass;
+use PHPUnit\Framework\Attributes\DataProvider;
 use PHPUnit\Framework\TestCase;
 use Spip\Composer\SpipInstaller;
 use Spip\Composer\SpipPaths;
 
-/**
- * @covers Spip\Composer\SpipInstaller
- */
+#[CoversClass(SpipInstaller::class)]
 class SpipInstallerTest extends TestCase
 {
     private SpipInstaller $installer;
@@ -39,7 +39,42 @@ class SpipInstallerTest extends TestCase
     {
         return [
             'library' => [
-                'expected' => null,
+                'expected' => false,
+                'type' => 'library',
+            ],
+            'classic' => [
+                'expected' => true,
+                'type' => 'spip-classic',
+            ],
+            'ecrire' => [
+                'expected' => true,
+                'type' => 'spip-ecrire',
+            ],
+            'prive' => [
+                'expected' => true,
+                'type' => 'spip-prive',
+            ],
+            'plugin' => [
+                'expected' => true,
+                'type' => 'spip-plugin',
+            ],
+        ];
+    }
+
+    #[DataProvider('dataPluginTypes')]
+    public function testSupports($expected, $type)
+    {
+        $package = new Package('spip/test', '1.0.0', '1.0.0.0');
+        $package->setType($type);
+
+        $this->assertEquals($expected, $this->installer->supports($package->getType()));
+    }
+
+    public static function dataPluginPaths()
+    {
+        return [
+            'library' => [
+                'expected' => dirname(__DIR__, 1) . '/vendor/spip/test',
                 'name' => 'spip/test',
                 'type' => 'library',
 
@@ -50,17 +85,17 @@ class SpipInstallerTest extends TestCase
                 'type' => 'spip-classic',
             ],
             'ecrire' => [
-                'expected' => './ecrire',
+                'expected' => './' . SpipPaths::BACK_OFFICE,
                 'name' => 'spip/test',
                 'type' => 'spip-ecrire',
             ],
             'prive' => [
-                'expected' => './prive',
+                'expected' => './' . SpipPaths::PRIVATE_TEMPLATE,
                 'name' => 'spip/test',
                 'type' => 'spip-prive',
             ],
             'plugin' => [
-                'expected' => './plugins/spip/test',
+                'expected' => './' . SpipPaths::PLUGINS . '/spip/test',
                 'name' => 'spip/test',
                 'type' => 'spip-plugin',
             ],
@@ -77,20 +112,7 @@ class SpipInstallerTest extends TestCase
         ];
     }
 
-    /**
-     * @dataProvider dataPluginTypes
-     */
-    public function testSupports($expected, $name, $type)
-    {
-        $package = new Package($name, '1.0.0', '1.0.0.0');
-        $package->setType($type);
-
-        $this->assertEquals(!is_null($expected), $this->installer->supports($package->getType()));
-    }
-
-    /**
-     * @dataProvider dataPluginTypes
-     */
+    #[DataProvider('dataPluginPaths')]
     public function testGetInstallPath($expected, $name, $type)
     {
         $package = new Package($name, '1.0.0', '1.0.0.0');